Skip to content

Conversation

@tsung-li
Copy link
Contributor

After support list of int in TensorType, TileType, now all test case passed

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tsung-li, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of 8-bit floating-point data types by introducing distinct IEEE 754 standard formats (e4m3fn and e5m2). Concurrently, it enhances the type system by enabling TensorType and TileType to be initialized directly with constant integer lists for their shapes, streamlining type definition for fixed-size tensors and tiles.

Highlights

  • New 8-bit Floating-Point Data Types: Introduced two distinct 8-bit floating-point data types, FP8E4M3FN and FP8E5M2, replacing the generic FP8 type. These new types adhere to specific IEEE 754 formats, providing more precise control over numerical representations.
  • Constant Shape Support for Tensor and Tile Types: Added new constructors to ShapedType, TensorType, and TileType that accept std::vector<int64_t> for defining shapes. This simplifies the creation of these types when their dimensions are constant integers, improving usability and clarity.
  • Python Binding and Utility Updates: Updated Python bindings, convenience constants, type resolvers, and Python printer utilities across the codebase to reflect the new 8-bit floating-point types and the enhanced shape constructors, ensuring seamless integration and correct behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tsung-li tsung-li changed the title Support list of int to TensorType, TileType fix(ir): Support list of int to TensorType, TileType Jan 31, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two main changes: support for creating TensorType and TileType with integer list shapes, and the splitting of the FP8 data type into FP8E4M3FN and FP8E5M2. The changes are well-implemented and consistent across the codebase. I've added a couple of suggestions: one to improve code maintainability by reducing duplication in TileType constructors, and another, more critical one, to add unit tests for the new list[int] shape support to ensure correctness and prevent regressions. Overall, this is a good enhancement to the library's usability from Python.

according nanobind doc `nb::arg("arg").none()` is value support
none, not value support default arg as None.
in type_resolver.py ans serveral other files, creating of ir.TensorType,
ir.TileType will use list of int
@lyfne123 lyfne123 merged commit 06bf645 into hw-native-sys:main Feb 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants