-
Notifications
You must be signed in to change notification settings - Fork 14
fix(ir): Support list of int to TensorType, TileType #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tsung-li, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of 8-bit floating-point data types by introducing distinct IEEE 754 standard formats (e4m3fn and e5m2). Concurrently, it enhances the type system by enabling Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two main changes: support for creating TensorType and TileType with integer list shapes, and the splitting of the FP8 data type into FP8E4M3FN and FP8E5M2. The changes are well-implemented and consistent across the codebase. I've added a couple of suggestions: one to improve code maintainability by reducing duplication in TileType constructors, and another, more critical one, to add unit tests for the new list[int] shape support to ensure correctness and prevent regressions. Overall, this is a good enhancement to the library's usability from Python.
according nanobind doc `nb::arg("arg").none()` is value support
none, not value support default arg as None.
in type_resolver.py ans serveral other files, creating of ir.TensorType, ir.TileType will use list of int
After support list of int in TensorType, TileType, now all test case passed