-
Notifications
You must be signed in to change notification settings - Fork 15
feat(ir): Change dtype FP8 to FP8e4m3fn and FP8e5m2 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tsung-li, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the representation of 8-bit floating-point data types within the system. Instead of a single generic 'FP8' type, it introduces two distinct IEEE 754 standard formats, 'FP8e4m3fn' and 'FP8e5m2', to accurately reflect the various FP8 standards used in practice. This enhancement improves precision and clarity in data type definitions and their usage across the codebase, with corresponding updates to C++ core, Python interfaces, and unit tests. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly replaces the generic FP8 data type with the more specific FP8e4m3fn and FP8e5m2 types, which is a great improvement for clarity and standard compliance. The changes are consistently applied across the C++ core, Python bindings, type stubs, and tests. I've found one minor issue regarding an un-updated __all__ export list in one of the Python modules. Otherwise, the implementation is solid.
FP8 has several standards, single DataType could not present all fp8 format, replace FP8 with two formats most frequently used
issue fixed, please check the latest code |
FP8 has several standards, single DataType could not present all fp8 format, replace FP8 with two formats most frequently used