Skip to content

Add ability to play videos from library#1

Closed
itsWindows11 wants to merge 3 commits intohuynhsontung:mainfrom
itsWindows11:main
Closed

Add ability to play videos from library#1
itsWindows11 wants to merge 3 commits intohuynhsontung:mainfrom
itsWindows11:main

Conversation

@itsWindows11
Copy link
Contributor

No description provided.

{
SetMinWindowSize();
rootFrame.Navigate(typeof(PlayerPage));
rootFrame.Navigate(typeof(MainPage));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the current LibVLC limitation, there can only be one instance of the media player element per LibVLC instance. This means the player will break if you navigate away from the PlayerPage.

You can see there is an inline Frame in PlayerPage that loads the MainPage to circumvent this.

Copy link
Contributor Author

@itsWindows11 itsWindows11 Mar 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the current LibVLC limitation, there can only be one instance of the media player element per LibVLC instance. This means the player will break if you navigate away from the PlayerPage.

You can see there is an inline Frame in PlayerPage that loads the MainPage to circumvent this.

I think you can init the player in the app initialization code and then that would fix it. You could revert that if you want for now.

@huynhsontung
Copy link
Owner

Rebased and merged in 7a61e37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants