feat: update to CaDiCaL version 2.2.0#252
feat: update to CaDiCaL version 2.2.0#252Dekker1 wants to merge 2 commits intohuub-solver:developfrom
Conversation
CodSpeed Performance ReportMerging this PR will degrade performance by 9.02%Comparing Summary
Performance Changes
|
|
Fix |
b623812 to
fe8a12d
Compare
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Thank you for the |
|
I think we can switch off the new lightweight preprocessing by setting the |
|
I also did a round of test on MiniZinc challenge instances from 2023 to 2025. There are some failures which relate to |
Light preprocessing is disabled in AllenZzw@0b4b76d |
de424ad to
d71eeb7
Compare
|
I've added it as a separate CLI option. It is a shame that it does not help. In general, it appears that the new version isn't necessarily beneficial. I think it might be worthwhile to merge this, but mostly just to stay up-to-date with the CaDiCaL development. Do you have any further concerns before we merge @AllenZzw? |
|
It appears that there are some fixs in 2.2.1 https://github.com/arminbiere/cadical/tree/rel-2.2.1. Do we want to merge that? CaDiCal 3.0.0 is also released several weeks ago, but there are some API changes. Maybe we would like to merge this version later. |
d71eeb7 to
4db48b0
Compare
No description provided.