Skip to content

Comments

feat: update to CaDiCaL version 2.2.0#252

Draft
Dekker1 wants to merge 2 commits intohuub-solver:developfrom
Dekker1:feat/cadical2.2
Draft

feat: update to CaDiCaL version 2.2.0#252
Dekker1 wants to merge 2 commits intohuub-solver:developfrom
Dekker1:feat/cadical2.2

Conversation

@Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Nov 26, 2025

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging this PR will degrade performance by 9.02%

Comparing Dekker1:feat/cadical2.2 (4db48b0) with develop (1f57128)

Summary

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 19 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
optimization[ccmcp_3_20_0] 179.7 ms 165.3 ms +8.73%
optimization[rcpsp_01] 315.4 ms 346.7 ms -9.02%

@AllenZzw
Copy link
Contributor

AllenZzw commented Dec 3, 2025

Fix int_pow in AllenZzw@5ad053a

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/huub-cli/src/lib.rs 87.50% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/huub-cli/src/main.rs 0.00% <ø> (ø)
crates/huub/src/lib.rs 64.08% <100.00%> (+0.02%) ⬆️
crates/huub/src/reformulate.rs 77.96% <100.00%> (+0.43%) ⬆️
crates/huub/src/solver/engine.rs 85.29% <100.00%> (-0.20%) ⬇️
crates/huub-cli/src/lib.rs 61.08% <87.50%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dekker1
Copy link
Contributor Author

Dekker1 commented Jan 7, 2026

Thank you for the IntPowBounds fix @AllenZzw. Did you manage to find where (and if) we can switch off the new presolving functionality?

@AllenZzw
Copy link
Contributor

AllenZzw commented Jan 7, 2026

I think we can switch off the new lightweight preprocessing by setting the preprocesslight option to 0. (https://github.com/arminbiere/cadical/blob/7b99c07f0bcab5824a5a3ce62c7066554017f641/src/options.hpp#L162)

@AllenZzw
Copy link
Contributor

AllenZzw commented Jan 7, 2026

I also did a round of test on MiniZinc challenge instances from 2023 to 2025. There are some failures which relate to int_value_procede, cumulative and BoolFormula. I will have a look at this.

@AllenZzw
Copy link
Contributor

AllenZzw commented Jan 8, 2026

Thank you for the IntPowBounds fix @AllenZzw. Did you manage to find where (and if) we can switch off the new presolving functionality?

Light preprocessing is disabled in AllenZzw@0b4b76d

@Dekker1 Dekker1 force-pushed the feat/cadical2.2 branch 2 times, most recently from de424ad to d71eeb7 Compare January 9, 2026 04:24
@Dekker1
Copy link
Contributor Author

Dekker1 commented Jan 9, 2026

I've added it as a separate CLI option. It is a shame that it does not help. In general, it appears that the new version isn't necessarily beneficial.

I think it might be worthwhile to merge this, but mostly just to stay up-to-date with the CaDiCaL development.

Do you have any further concerns before we merge @AllenZzw?

@AllenZzw
Copy link
Contributor

AllenZzw commented Jan 9, 2026

It appears that there are some fixs in 2.2.1 https://github.com/arminbiere/cadical/tree/rel-2.2.1. Do we want to merge that?

CaDiCal 3.0.0 is also released several weeks ago, but there are some API changes. Maybe we would like to merge this version later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants