Add the ability to set WP_HOME #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a user to override the value in the wp_options table (useful for development instances) as well as reduce database calls on production instances. This also applies to wp_site_url and so I have added this use to the description for that parameter. I have added in some whitespace cleanup for the wp_site_url and wp_home tags in the wp-config.erb.php - it may be desirable to replicate this with all of the if/end statements in both template files to avoid unnecessary whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a user to override the value in the wp_options table
(useful for development instances) as well as reduce database calls on
production instances. This also applies to wp_site_url and so I have
added this use to the description for that parameter.
I have added in some whitespace cleanup for the wp_site_url and wp_home
tags in the wp-config.erb.php - it may be desirable to replicate this
with all of the if/end statements in both template files to avoid
unnecessary whitespace.