Feat/add executors and refactor services #110

cardosofede · 2026-01-21T14:19:52Z

Summary

This PR introduces a major architectural refactoring to consolidate connector management and adds native executor support via the API.

Key Changes

New Services Architecture:

UnifiedConnectorService (replaces ConnectorManager and connector management from MarketDataProvider): Single source of truth for all connector instances.
Manages two types of connectors:
- Trading connectors: Authenticated, per-account, with order tracking
- Data connectors: Non-authenticated, shared, for public market data
MarketDataService (replaces MarketDataFeedManager): Centralized market data access (candles, order books, prices) with automatic feed lifecycle
management
TradingService: Centralized trading operations with AccountTradingInterface - a ScriptStrategyBase-compatible interface that executors can use
ExecutorService: Manages Hummingbot executors directly via API without Docker containers or full strategy setup

New API Endpoints:

/executors - Full CRUD for executor management (Position, Grid, DCA, TWAP, Arbitrage, XEMM, Order executors)
/rate-oracle - Rate oracle configuration and rate queries

New Features:

Position Hold tracking: Aggregates positions from executors stopped with keep_position=true, tracking buy/sell amounts, breakeven prices, and
realized/unrealized PnL
Order book tracker registration: Proper management of order book trackers per trading pair with automatic cleanup
Executor persistence: Database storage of executor state and history

Removed:

services/market_data_feed_manager.py (replaced by MarketDataService)
utils/connector_manager.py (replaced by UnifiedConnectorService)

Testing Recommendations

Connector Management

Create trading connectors for multiple accounts and verify isolation
Test get_best_connector_for_market() returns trading connector when available
Verify data connector sharing (same connector used across requests)
Test order book tracker registration and removal on trading pairs
Test connector restart/recovery scenarios

Executor Service

Create each executor type: position_executor, grid_executor, dca_executor, twap_executor, arbitrage_executor, xemm_executor, order_executor
Test executor stop with keep_position=false (should close position)
Test executor stop with keep_position=true (should update PositionHold)
Verify executor status transitions (RUNNING → TERMINATED)
Test executor filtering by account, connector, trading pair, status
Verify database persistence of executor history

Trading Service

Place buy/sell orders through the API
Test order cancellation
Verify PositionAction handling for perpetual connectors (OPEN/CLOSE)
Test AccountTradingInterface.connectors property returns correct connectors

Market Data Service

Start candle feeds and verify data
Test order book access via /market-data/order-book
Verify feed cleanup after timeout period
Test price queries through rate oracle

Rate Oracle

GET /rate-oracle/sources - list available sources
GET /rate-oracle/config - get current configuration
PUT /rate-oracle/config - update source/quote token
POST /rate-oracle/rates - query specific rates

Integration/E2E Tests

Create executor → place orders → stop executor → verify position hold
Multiple accounts trading same market simultaneously
Service restart and state recovery (executors should reload from DB)
Error handling: invalid executor config, connector not found, insufficient balance

rapcmia · 2026-01-23T08:35:37Z

Commit 57be279

Successfully build docker image
Tested using docker build
Successfully setup and localhost:8000 ✅

Portfolio endpoints using `binance`, `kucoin` and `hyperliquid_perpetual` ✅

/portfolio/state (POST) ok
/portfolio/history (POST) ok
/portfolio/distribution (POST) ok
/portfolio/accounts-distribution (GET) ok

Trading endpoints using `kucoin` and `hyperliquid_perpertual` specifically HIP-3 pairs `XYZ:AMZN-USD`

/trading/orders (POST) ok
/trading/{account}/{connector}/orders/{id}/cancel (POST) ok
/trading/positions (POST) ok
/trading/orders/active (POST) ok
/trading/orders/search (POST) ❌
- I tried to search starting from 00:00 UTC and still was not able to fetch all historical orders
- Check DB orders table and did not find any orders recorded (tested with kucoin also)
- Crosschecking this behavior on main branch, able to record orders ✅
/trading/trades (POST) ❌
- We completed 2 market orders from kucoin and hyperliquid_perpetual but non recorded on db
/trading/{account}/{connector}/position-mode (POST/GET) ok
/trading/{account}/{connector}/leverage (POST) ok
/trading/funding-payments in progress

Pending tests:

Test executor routes

Incase needed, here is test logs: 23012026.log

- Add recover_positions_from_db() method to ExecutorService - Load executors with POSITION_HOLD close type on startup - Reconstruct _positions_held tracking from final state - Add get_position_hold_executors() to ExecutorRepository Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

rapcmia · 2026-01-26T11:03:19Z

Commit fc6eaf6

/trading/orders/search (POST) ❌

Fixed, all orders are recorded to db along with status (active or inactive state)
- trading/orders/search (POST) ✅
- /trading/trades (POST) ✅

position_executor ✅
grid_executor ✅
- Tested using hyperliquid_perpetual (HYPE-USD and XYZ:AMZN-USD)
- Successfully started executor then search, check and summary ok
- Stop then terminate ok
- Orders and positions are successfully created on exchange. Matched the responses return by hummingbot-api via curl ok
order_executor
- Test using hyperliquid_perpetual using (XYZ:AMZN-USD)
  - Successfully placed order on buy and sell side on LIMIT, LIMIT_MAKER with related price
  - position_action OPEN and CLOSE ok
  - All order_executors were stopped but the status remains “shutting down” even after waiting 1-2 minutes
  - Order executors remain stuck in shutting down with is_active:false and cannot be deleted with response of not found in completed list, indicating that it never transitioned to complete or terminated state after stop ❌
```
# /executors/BXwsK4sPDkxR5pTnxXA4J5nZcB8j2mxVm8gvQVJTT7z
curl -s -u admin:admin -X DELETE http://localhost:8000/executors/BXwsK4sPDkxR5pTnxXA4J5nZcB8j2mxVm8gvQVJTT7z | jq
{
  "detail": "Executor BXwsK4sPDkxR5pTnxXA4J5nZcB8j2mxVm8gvQVJTT7z not found in completed list"
}
```
    - I relaunch hummingbot-api and tried to search for these affected executor_ids and responded empty, however when i check postgress->executor table, i see these executors are on RUNNING state
    - Steps to reproduce:
      - Place a successful order_executor order on preferred exchange then initiate a executor/{executor_id}/stop
      - Check status of the executor_id using GET /executors/{executor_id} or try DELETE /executors/{executor_id}

Test logs: 23012026.log

rapcmia · 2026-01-27T08:22:20Z

Commit fc6eaf6

Order executors remain stuck in shutting down with is_active:false and cannot be deleted with response of not found in completed list, indicating that it never transitioned to complete or terminated state after stop ❌

Built docker image from hummingbot==20260126.dev1
Fixed error on price when market order is placed ✅
Status of executor terminated

arbitrage_executor

Error calculating proftability, test attempt 2/2 ❌

### config
{
    "type": "arbitrage_executor", 
    "connector_name": "binance", 
    "trading_pair": "SOL-FDUSD", 
    "buying_market": {
  	  "connector_name": "binance", 
  	  "trading_pair": "SOL-FDUSD"
  	  }, 
    "selling_market": {
  	  "connector_name": "kucoin", 
  	  "trading_pair": "SOL-USDT"}, 
  	  "order_amount": 0.1, 
  	  "min_profitability": 0.01, 
  	  "timestamp": 1769503895.5714095
  	  }
  	  

### hummingbot logs 
INFO:     172.20.0.1:55904 - "POST /executors/ HTTP/1.1" 201 Created
2026-01-27 08:51:36,687 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:37,688 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:38,689 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:39,690 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:40,691 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:41,692 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:42,692 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:43,694 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:44,695 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:45,696 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:46,696 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:47,697 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:48,698 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:49,699 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:50,700 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:52,702 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:53,703 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:54,703 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:55,705 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:56,705 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:57,706 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:58,708 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'
2026-01-27 08:51:59,708 - hummingbot.strategy_v2.executors.arbitrage_executor.arbitrage_executor - ERROR - Error calculating profitability: unsupported operand type(s) for *: 'decimal.Decimal' and 'NoneType'

Check this setup with hummingbot generic.arbitrage-controller and im able to start without the error above ✅

xemm_executor

Could not fetch conversion rate for USDT-FDUSD ❌

### xemm_executor config
{
    "type": "xemm_executor", 
    "connector_name": "binance", 
    "trading_pair": "SOL-FDUSD", 
    "buying_market": {
  	  "connector_name": "binance", 
  	  "trading_pair": "SOL-FDUSD"
  	  }, 
    "selling_market": {
  	  "connector_name": "kucoin", 
  	  "trading_pair": "SOL-USDT"
  	  }, 
    "maker_side": 1, 
    "order_amount": 0.1, 
    "min_profitability": 0.001, 
    "target_profitability": 0.005, 
    "max_profitability": 0.008, 
    "timestamp": 1769504865.2716665
    }

### hummingbot-api logs
INFO:     172.20.0.1:53236 - "POST /executors/ HTTP/1.1" 201 Created
2026-01-27 09:07:46,823 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:46,823 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error fetching conversion rate for USDT-FDUSD: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:46,823 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error calculating trade profitability: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:48,824 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:48,825 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error fetching conversion rate for USDT-FDUSD: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:48,825 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error calculating trade profitability: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:50,827 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:50,827 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error fetching conversion rate for USDT-FDUSD: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:50,827 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error calculating trade profitability: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:52,829 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:52,829 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error fetching conversion rate for USDT-FDUSD: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:52,829 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error calculating trade profitability: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:54,832 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:54,832 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error fetching conversion rate for USDT-FDUSD: Could not fetch conversion rate for USDT-FDUSD
2026-01-27 09:07:54,832 - hummingbot.strategy_v2.executors.xemm_executor.xemm_executor - ERROR - Error calculating trade profitability: Could not fetch conversion rate for USDT-FDUSD

Not able to reproduce this error on hummingbot generic.xemm_multiple_levels.py ✅

rapcmia

Tested using docker build on Ubuntu24.04
Reviewed Dev's shared APi playbook
Healthcheck on hummingbot-api ✅
Portfolio endpoints using binance, kucoin and hyperliquid_perpetual (hip-3 pairs)
Tested new executor endpoints specifically position_executor, grid_executor and order_executor
- POST /executors/ (create)
- POST /executors/search (list/search)
- GET /executors/summary
- GET /executors/{executor_id}
- POST /executors/{executor_id}/stop
- DELETE /executors/{executor_id} optional
- GET /executors/positions/summary
- GET /executors/types/available
- GET /executors/types/{executor_type}/config
Reported issues found on this PR and compared to development branch has been fixed

cardosofede added 11 commits January 20, 2026 20:25

(feat) add executors repository

e662e24

(feat) add order book tracking registry and removal

03cee63

(feat) add executors model

5c2670b

(feat) add executors repositor

29389d7

(feat) remove filter

0af64f5

(feat) re-engineer market data servivce

d1b8f8f

(feat) simplify accounts service

78d68ec

(feat) crete unified connector service replacing utils

c533ed1

(feat) add trading service

1befbe0

(feat) add executor service and router

87a30e3

(feat) update imports

ae3fb50

rapcmia self-requested a review January 21, 2026 14:20

cardosofede added 6 commits January 21, 2026 15:45

(feat) fix ob start

dab73ec

(feat) restart ob tracker and state

2052405

(feat) add position hold

98cf59e

(feat) clean up code

9f8ee26

(feat) add position hold

8e7ac76

(feat) clean up connector code

57be279

cardosofede and others added 3 commits January 23, 2026 15:44

(feat) initialize connectors for db

8b4102e

(feat) prevent double initialization

fc6eaf6

rapcmia approved these changes Jan 27, 2026

View reviewed changes

david-hummingbot merged commit 0442224 into main Jan 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add executors and refactor services #110

Feat/add executors and refactor services #110

Uh oh!

cardosofede commented Jan 21, 2026 •

edited

Loading

Uh oh!

rapcmia commented Jan 23, 2026 •

edited

Loading

Uh oh!

rapcmia commented Jan 26, 2026 •

edited

Loading

Uh oh!

rapcmia commented Jan 27, 2026 •

edited

Loading

Uh oh!

rapcmia left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Feat/add executors and refactor services #110

Feat/add executors and refactor services #110

Uh oh!

Conversation

cardosofede commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rapcmia commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Portfolio endpoints using binance, kucoin and hyperliquid_perpetual ✅

Trading endpoints using kucoin and hyperliquid_perpertual specifically HIP-3 pairs XYZ:AMZN-USD

Uh oh!

rapcmia commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rapcmia commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

arbitrage_executor

xemm_executor

Uh oh!

rapcmia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cardosofede commented Jan 21, 2026 •

edited

Loading

rapcmia commented Jan 23, 2026 •

edited

Loading

Portfolio endpoints using `binance`, `kucoin` and `hyperliquid_perpetual` ✅

Trading endpoints using `kucoin` and `hyperliquid_perpertual` specifically HIP-3 pairs `XYZ:AMZN-USD`

rapcmia commented Jan 26, 2026 •

edited

Loading

rapcmia commented Jan 27, 2026 •

edited

Loading