This repository was archived by the owner on Nov 15, 2024. It is now read-only.
add option to disable numa, still on by default#50
Open
Conversation
schofield
changed the title
schofield
changed the title
tasks/main.yml
Outdated
| - name: Create Humio SystemD template configuration | ||
| tags: humio-update | ||
| template: | ||
| src: "humio.service.j2" |
There was a problem hiding this comment.
Wouldn't it be better just to make a small adjustment to the existing template which would leave out the /usr/bin/numactl --cpunodebind=${NUMA_NODES} --membind=${NUMA_NODES} part of ExecStart command?
Then we don't have two very similar templates to maintain.
Contributor
Author
There was a problem hiding this comment.
@SaaldjorMike I made the change you suggested. Have a look again please.
schofield
force-pushed
the
disable-numa-option
branch
from
be0db25 to
3f6551b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.