[Job Launcher] Remove CVAT job validations and content moderation code#3846
Open
[Job Launcher] Remove CVAT job validations and content moderation code#3846
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
Dzeranov
reviewed
Mar 27, 2026
Contributor
Dzeranov
left a comment
Dzeranov
left a comment
There was a problem hiding this comment.
- Please, create a dedicated branch to merge this PR to as we discussed
- There are still leftovers related to content moderation -
gcv.ts,ErrorContentModeration, some vars in constants, etc.
packages/apps/job-launcher/server/src/modules/cron-job/cron-job.service.ts
Outdated
Show resolved
Hide resolved
Dzeranov
reviewed
Mar 30, 2026
Contributor
Dzeranov
left a comment
Dzeranov
left a comment
There was a problem hiding this comment.
Please, address these changes to the migration file, the rest looks good to me.
Contributor
There was a problem hiding this comment.
If I'm not mistaken there're a few things missing:
- You need to delete
content-moderation-requeststable. - Detele
content-moderationcron-job record. - Change jobs statuses
moderation_passed,possible_abuse_in_reviewandunder_moderationaccordingly.
It all can be done manually from a db but I don't like this approach.
…on and old status handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3806
Context behind the change
How has this been tested?
Release plan
Deploy migrations and remove the following vars from env:
Potential risks; What to monitor; Rollback plan
Check HCaptcha Jobs still working