Skip to content

Fix eval prompt collision with model flag #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KevinMeisel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix eval prompt collision with model flag #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/upskill/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,31 @@

console = Console()

KNOWN_PROVIDERS = ("anthropic", "openai", "generic")


def _model_has_provider(model: str) -> bool:
return any(model.startswith(f"{provider}.") for provider in KNOWN_PROVIDERS)


def _apply_provider_to_models(models: list[str], provider: str | None) -> list[str]:
if not provider:
return models
normalized: list[str] = []
for model in models:
if _model_has_provider(model):
normalized.append(model)
else:
normalized.append(f"{provider}.{model}")
return normalized


@asynccontextmanager
async def _fast_agent_context() -> AsyncIterator[object]:
fast = FastAgent(
"upskill",
ignore_unknown_args=True,
parse_cli_args=False, # Prevent FastAgent from consuming upskill CLI flags (e.g. -m).
)

@fast.agent()
Expand Down Expand Up @@ -719,6 +738,8 @@ async def _eval_async(
if not models:
models = [config.effective_eval_model]

models = _apply_provider_to_models(models, provider)

is_benchmark_mode = len(models) > 1 or num_runs > 1

async with _fast_agent_context() as agent:
Expand Down