Fixed some errors to make it easier for first-time users.#72
Open
MingHui-Fang wants to merge 2 commits intohuggingface:mainfrom
Open
Fixed some errors to make it easier for first-time users.#72MingHui-Fang wants to merge 2 commits intohuggingface:mainfrom
MingHui-Fang wants to merge 2 commits intohuggingface:mainfrom
Conversation
Author
|
There is a bug with the handling of the variables parler-tts/training/run_parler_tts_training.py Lines 433 to 437 in 8b8c576 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, I ran into some issues when I used the official code, and I've seen other people raise the same issue, so maybe that's worth addressing.
Many users do not choose to use a 600M model due to GPU limitations, and will often use helpers/model_init_scripts/init_dummy_model_with_encodec.py or helpers/model_init_scripts/init_dummy_model.py.
However, the configurations in these two files have some potential problems for first-time users (Such as #63 (comment) and #66 (comment)), and it would probably be better if they could be fixed and comments added.
In addition, as users may change the model architecture, leading to errors, it might be possible to consider refinements training/run_parler_tts_training.py.
The above content is merely a personal suggestion. Please forgive any shortcomings.