feat: add inverse trigonometric functions (asin, acos, atan)#3338
Open
AndrewTKent wants to merge 1 commit intohuggingface:mainfrom
Open
feat: add inverse trigonometric functions (asin, acos, atan)#3338AndrewTKent wants to merge 1 commit intohuggingface:mainfrom
AndrewTKent wants to merge 1 commit intohuggingface:mainfrom
Conversation
Add asin, acos, and atan operations with full backend support: - CPU via UnaryOpT trait with MKL/Accelerate vectorization - CUDA kernels for f32, f64, f16, bf16, and fp8e4m3 - Metal shaders for f32, f16, bf16 (contiguous + strided) Includes gradient computation for autodiff: - d/dx asin(x) = 1/√(1-x²) - d/dx acos(x) = -1/√(1-x²) - d/dx atan(x) = 1/(1+x²) Tests validated against PyTorch reference values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
asin,acos, andatanwith full autodiff support across all backends.Changes
tensor.rs,op.rsbackprop.rsmkl.rs,accelerate.rscuda_utils.cuh,unary.cuunary.metal,unary.rs,metal_backend/mod.rstensor_tests.rs,grad_tests.rsBackend Coverage
Gradients
Test values validated against PyTorch.
Usage
Closes #3270