修正 audio 模組 AudioQueue 生命週期與緩衝區管理 #43

TwhomeGH · 2026-01-01T07:45:04Z

概述

修正 audio 模組中 AudioQueue 緩衝區管理、callback race condition 以及記憶體釋放問題，並改善 Xcode genic/ios 打包可編譯性。

問題

audio_destroy() 先 Dispose queue 後釋放 buffers，可能造成 callback 存取已釋放 buffer crash。
AudioQueueBuffer 的 mUserData 可能發生非法記憶體讀取造成crash
callback 在 audio 銷毀期間沒有防護，存在 race condition。
legacy loc/mem offset 實作不再使用。
audio_clear() 未檢查 null，可能 crash。

修正

新增 struct audio.isStopping，callback 在 destroy 期間會跳過。
將 mUserData 由指向可變動記憶體的指標改為穩定的 buffer index，避免音訊非同步 callback 中可能發生的非法記憶體存取與 crash。
audio_destroy() 釋放順序：
- Stop queue
- Free AudioQueue buffers
- Free silence buffer
- Dispose queue
- Free ctx->rcm.rc
- Free ctx
清理 loc/mem 陣列，RecycleChain 改用 array 索引。
audio_clear() 增加 null 檢查。
audio_queue_callback() 增加 isStopping 檢查。
調整 Xcode genic/ios 打包問題。

影響

非破壞性修正，不改變 API。
增加播放穩定性，避免 crash。
減少 legacy code，維護性更高。

測試

Xcode 編譯和打包測試成功 (genic/ios)。
安裝後應用啟動與基本使用正常。
尚未進行多次 start/stop 或實際音訊播放壓力測試。

添加了isStopping标志来管理音频队列停止。更新了音频缓冲器的内存管理，并改进了回调处理。此區段原始可能存在內存異常讀取可能會導致應用崩潰問題 "vmRegionInfo" : "0 is not in any region. Bytes before following region: 4366663680\n REGION TYPE START - END [ VSIZE] PRT\/MAX SHRMOD REGION DETAIL\n UNUSED SPACE AT START\n---> \n __TEXT 104460000-1044cc000 [ 432K] r-x\/r-x SM=COW \/var\/containers\/Bundle\/Application\/3A882EEF-290C-419B-9D72-85B1D7EB9598\/OpenParsec.app\/OpenParsec", "exception" : {"codes":"0x0000000000000001, 0x0000000000000000","rawCodes":[1,0],"type":"EXC_BAD_ACCESS","signal":"SIGSEGV","subtype":"KERN_INVALID_ADDRESS at 0x0000000000000000"}, "termination" : {"flags":0,"code":11,"namespace":"SIGNAL","indicator":"Segmentation fault: 11","byProc":"exc handler","byPid":41615}, "vmregioninfo" : "0 is not in any region. Bytes before following region: 4366663680\n REGION TYPE START - END [ VSIZE] PRT\/MAX SHRMOD REG ⚠️待實際調試檢查

工作流測試手動調試測試生產ipa吧

工作流測試不使用真機打包

修正用存在的模擬器

Updated variable type for lastbuf and improved comments for clarity.

Modify audio_clear function to return early if queue is not initialized and adjust in_use calculation.

Changed 'release__nightly' input to be optional with a default value of true. Updated condition for 'release__nightly' job to include 'patch-1' branch.

Added FPS setting with selectable options for frame rates.

Added fpsPerFrame variable and loading logic from UserDefaults.

Replaced hardcoded FPS with dynamic setting and added updateFPS method.

Refactor metricInfo construction for better readability and include GLK FPS parameter.

Updated the build timestamp format to include date and time in a more detailed manner.

Added methods to calculate actual and delta FPS.

Removed average FPS logging and updated delta FPS formatting.

Removed commented-out SwiftUI and GLKit code for ParsecGLKViewController.

hugeBlack · 2026-01-10T04:13:33Z

看你把Metal相关的注释去掉了，你是解决了Metal渲染吗？

TwhomeGH added 30 commits January 1, 2026 13:05

Allow code signing in build workflow

f1f5c7d

工作流測試手動調試測試生產ipa吧

Update build.yml for iOS Simulator destination

2059ef7

工作流測試不使用真機打包

Simplify CODE_SIGNING_ALLOWED in build.yml

d45aecd

Refactor xcodebuild command in build.yml

d631d09

Update build.yml

7fb8f2d

修正用存在的模擬器

Fix formatting in build.yml for xcodebuild command

98d2f73

Add architecture parameter to xcodebuild command

c8a324e

Remove architecture flag from xcodebuild command

5656752

Update iOS Simulator architecture in build.yml

a77c9b7

Change iOS build destination to generic platform

16523a7

Change lastbuf to intptr_t and refine comments

ab608ed

Updated variable type for lastbuf and improved comments for clarity.

Add stdint.h include to audio.c

b019e34

Fix audio_clear early return and update in_use calculation

2c72d5f

Modify audio_clear function to return early if queue is not initialized and adjust in_use calculation.

Update condition for nightly release workflow

50a289f

Fix conditional expression in nightly release job

437d365

Change nightly release input to required

0e6f211

Make nightly release input optional and update conditions

b1692c9

Changed 'release__nightly' input to be optional with a default value of true. Updated condition for 'release__nightly' job to include 'patch-1' branch.

Implement FPS setting in SettingsView

46f5e75

Added FPS setting with selectable options for frame rates.

Add fpsPerFrame setting and load logic

e007e1d

Added fpsPerFrame variable and loading logic from UserDefaults.

Use dynamic FPS setting in GLKViewController

2d9f6cb

Replaced hardcoded FPS with dynamic setting and added updateFPS method.

Refactor FPS update logic into ParsecRenderCenter

cad40ee

Add onChange handler for fpsPerFrame setting

9181900

Refactor metricInfo and add GLK FPS

d1fbf7b

Refactor metricInfo construction for better readability and include GLK FPS parameter.

Refactor metricInfo string concatenation

507f284

Add currentFPS method to ParsecGLKViewController

972c1b0

Add current FPS metric to metricInfo

fe8497e

Fix currentFPS method to return framesPerSecond

eae3e26

Add return type to currentFPS function

c73b168

Change currentFPS return type to Int?

0c0d8f0

TwhomeGH and others added 29 commits January 2, 2026 04:29

Refactor metricInfo construction using metricsArray

6d0534d

Add title to nightly release in build workflow

d724019

Change title to name in nightly release workflow

4a88ece

Refine build timestamp format in workflow

3a32688

Updated the build timestamp format to include date and time in a more detailed manner.

Format CFPS output with newline for better readability

bc2b864

Implement FPS calculation methods

99c4802

Added methods to calculate actual and delta FPS.

Add average and delta FPS metrics to ParsecView

c9b86fb

Refactor onChange handler for fpsPerFrame

10566fb

Refactor FPS metrics logging

329e674

Removed average FPS logging and updated delta FPS formatting.

Clean up unused code in ParsecGLKViewController

88afa48

Removed commented-out SwiftUI and GLKit code for ParsecGLKViewController.

Add Metal rendering support to ParsecResolution

fc688ea

Implement renderMetalFrame function

a8c49bf

Update ParsecMetalRenderer.swift

0d397bd

Update ParsecMetalViewController.swift

3a2090f

Update ParsecGLKViewController.swift

e929220

Update ParsecMetalViewController.swift

e29f137

Update ParsecMetalRenderer.swift

71f52eb

Update ParsecGLKViewController.swift

1226902

Update ParsecMetalRenderer.swift

6be080a

Update ParsecMetalRenderer.swift

2ca8d62

Update ParsecView.swift

b6a4ff1

Update ParsecSDKBridge.swift

745d716

Update ParsecSDKBridge.swift

f842d48

Update CParsec.swift

5a9d663

Update CParsec.swift

d987fa7

Update CParsec.swift

bfa550e

Update ParsecSDKBridge.swift

8a7e182

調整

6da9b27

修正精度問題

6eee8d4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

修正 audio 模組 AudioQueue 生命週期與緩衝區管理 #43

修正 audio 模組 AudioQueue 生命週期與緩衝區管理 #43

Uh oh!

TwhomeGH commented Jan 1, 2026 •

edited

Loading

Uh oh!

hugeBlack commented Jan 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

修正 audio 模組 AudioQueue 生命週期與緩衝區管理 #43

Are you sure you want to change the base?

修正 audio 模組 AudioQueue 生命週期與緩衝區管理 #43

Uh oh!

Conversation

TwhomeGH commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概述

問題

修正

影響

測試

Uh oh!

hugeBlack commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TwhomeGH commented Jan 1, 2026 •

edited

Loading

hugeBlack commented Jan 10, 2026 •

edited

Loading