Skip to content

Optimization (safeMul): Replace jumpi with jump for unconditional branching #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joaonevess wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Optimization (safeMul): Replace jumpi with jump for unconditional branching #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1d26d5
optimize safeMul to reduce gas cost by 5 units
joaonevess Jun 24, 2024
0837b0c
Optimization (Trigonometry): removed redundant iszero iszero sequence
joaonevess Jun 24, 2024
5e6f0a6
Merge pull request #1 from joaonevess/optimization/trigonometry
joaonevess Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/math/SafeMath.huff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
dup1 // [num1, num1, num2]
is_not_zero jumpi // [num1, num2]
mul // [result]
0x01 is_not_overflow jumpi
is_not_overflow jump
is_not_zero: // [num1, num2]
dup2 // [num2, num1, num2]
dup2 // [num1, num2, num1, num2]
Expand Down
3 changes: 1 addition & 2 deletions src/math/Trigonometry.huff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@

dup4 // [angle, is_odd_quadrant, index, interp, angle]
[QUADRANT_HIGH_MASK] // [QUADRANT_HIGH_MASK, angle, is_odd_quadrant, index, interp, angle]
and // [QUADRANT_HIGH_MASK & angle, is_odd_quadrant, index, interp, angle]
iszero iszero // [is_negative_quadrant, is_odd_quadrant, index, interp, angle]
and // [is_negative_quadrant, is_odd_quadrant, index, interp, angle]

// Jump past updating the index if `is_odd_quadrant` is true
dup2 is_odd_q jumpi // [is_negative_quadrant, is_odd_quadrant, index, interp, angle]
Expand Down