⚡️ Optimize constructor for small bytecodes #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertleifke
approved these changes
Feb 3, 2025
robertleifke
left a comment
robertleifke
left a comment
There was a problem hiding this comment.
Left a comment about the RETURNDATASIZE being zero after a DELEGATECALL. Let me know if this a non-issue, otherwise looks good to me!
| RETURNDATASIZE, | ||
| MSTORE, | ||
| MSIZE, | ||
| RETURNDATASIZE, |
There was a problem hiding this comment.
nice use of RETURNDATASIZE. Have you thought about what would happen if generate_default_constructor() is executed after a DELEGATECALL via a proxy? It's really the only scenario I can think of where RETURNDATASIZE could be zero.
Contributor
Author
There was a problem hiding this comment.
The assumption is that it's going to be a standalone constructor but I'll add a comment 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.