Skip to content

Fixes infinite create board loop #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
discorick wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes infinite create board loop #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
591292c
Fixes infinite loop, adds styling to deal with it, extends styling to…
discorick Aug 9, 2016
67318f7
Refactors to BEM and cleans up some markup
rauhryan Aug 29, 2016
1e3d528
adds analytics paths to determine retry or abandons
rauhryan Aug 31, 2016
6298ebf
Merge pull request #364 from huboard/discorick/fix-infinite-board-cre…
discorick Sep 20, 2016
41aaab9
Tweaks copy
discorick Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/stylesheets/application.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
@import "breadcrumbs";
@import "account";
@import "sidebar";
@import "board/create";

form {
margin: 0;
Expand Down
34 changes: 34 additions & 0 deletions app/assets/stylesheets/board/create.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
.create-new-board__container {
max-width: 600px;
margin-left: auto;
margin-right: auto;
padding-bottom: 30px;
font-size: 15px;
}

.create-new-board__message {
margin: 0px auto;
}

.create-new-board__list {
list-style: none;
padding-left: 10px;
text-align: left;
&__item {
border-left-style: solid;
border-left-color: $lightGrey;
padding-left: 10px;
margin-bottom: 14px;
&--error {
border-left-color: $red;
}
}
}

.create-new-board__labels {
@include display(flex);
@include align-items(center);
@include justify-content(center);
padding-bottom: 10px;
font-size: 16px;
}
8 changes: 5 additions & 3 deletions app/controllers/board_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def index

def create_board
return not_found unless logged_in?
@parameters = params
@parameters = params || []
@repo = gh.repos(params[:user],params[:repo])

board = huboard.board(params[:user], params[:repo])
Expand All @@ -34,11 +34,13 @@ def create_board

def create
begin
huboard.board(params[:user], params[:repo]).create_board
@event = 'board_created'
board = huboard.board(params[:user], params[:repo])
board.create_board
rescue Ghee::UnprocessableEntity
redirect_to "/#{params[:user]}/#{params[:repo]}/"
end

return redirect_to action: 'create_board', create_failed: true unless board.has_board?
redirect_to "/#{params[:user]}/#{params[:repo]}/"
end
end
Expand Down
101 changes: 81 additions & 20 deletions app/views/board/create_board.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,82 @@
<div class="instructions drop-shadow">
<h2> We noticed your repository issue tracker is not yet configured for HuBoard</h2>
<% if @repo && @repo['permissions'] && @repo['permissions']['push'] %>
<p> No worries, HuBoard can automatically get you started with a default label configuration </p>
<p> HuBoard will create the following labels </p>
<ol start="0">
<li> Backlog </li>
<li> Ready </li>
<li> Working </li>
<li> Review </li>
<li> Done </li>
</ol>
<%= form_tag 'create' do %>
<input class="btn primary" type="submit" value="Yes, Do it for me!" data-analytics-path='/board/creating'/>
<a href="<%= @repo['html_url'] %>/issues" target="_blank" >No thanks, I want to do this manually</a>
<% end %>
<% else %>
<p> Unfortunately, HuBoard doesn't have permission to fix that for you. </p>
<p> You'll need to head over to <a href="<%= @repo['html_url'] %>">GitHub</a> for that</p>
<% end %>
<div class="instructions drop-shadow create-new-board">
<div class="create-new-board__container">
<% if @parameters['create_failed']%>
<h2> Oops! </h2>
<div class="create-new-board__message">
<h3> HuBoard is unable to create a board for you! </h3>
<ul class="create-new-board__list">
<li class="create-new-board__list__item create-new-board__list__item--error">
<p>
You will need write permissions to <b><%= @parameters['user'] %>/<%= @parameters['repo'] %></b>
</p>
<% if @repo['owner'] && @repo['owner']['type'] == "Organization" %>
<p>
<b><%= @repo['owner']['login'] %></b> is a GitHub Organization: <a href="https://help.github.com/articles/disabling-third-party-application-restrictions-for-your-organization/" target="blank">Please ensure no access restrictions are present</a>
</p>
<% end %>
<p>
<a href="mailto:support@huboard.com">Talk to us!</a>
</p>
</li>
</ul>
<%= form_tag 'create', class: 'create-new-board__form' do %>
<input class="btn btn-large btn-primary" type="submit" value="Try again" data-analytics-path='/board/creating/retry'/>
<a href="/dashboard" class="btn btn-large primary" data-analytics-path='/board/creating/abandon'>
Go Home
</a>
<% end %>
</div>
<% elsif @repo && @repo['permissions'] && @repo['permissions']['push'] %>
<h2> <%= @parameters['user'] %>/<%= @parameters['repo'] %> is not yet setup for HuBoard</h2>
<div class="create-new-board__message">
<h3> We can automatically get you started with a default label configuration: </h3>
<br/>
<div class="create-new-board__labels">
<div>
<p> Allow HuBoard to create the following labels? </p>
</div>
<div>
<ul class="create-new-board__list">
<li class="create-new-board__list__item"> 0 - Backlog </li>
<li class="create-new-board__list__item"> 1 - Ready </li>
<li class="create-new-board__list__item"> 2 - Working </li>
<li class="create-new-board__list__item"> 3 - Review </li>
<li class="create-new-board__list__item"> 4 - Done </li>
</ul>
</div>
</div>
<%= form_tag 'create', class: 'create-new-board__form' do %>
<input class="btn btn-large btn-primary" type="submit" value="Yes, Do it for me!" data-analytics-path='/board/creating'/>
<a href="<%= @repo['html_url'] %>/issues" target="_blank" data-analytics-path='/board/creating/manual' class='btn btn-large' >
Create columns manually
</a>
<% end %>
</div>
<% else %>
<h2> <%= @parameters['user'] %>/<%= @parameters['repo'] %> is not yet setup for HuBoard</h2>
<div class="create-new-board__message">
<ul class="create-new-board__list">
<li class="create-new-board__list__item create-new-board__list__item--error">
<p>
You will need write permissions to <b><%= @parameters['user'] %>/<%= @parameters['repo'] %></b>
</p>
<% if @repo['owner'] && @repo['owner']['type'] == "Organization" %>
<p>
<b><%= @repo['owner']['login'] %></b> is a GitHub Organization: <a href="https://help.github.com/articles/disabling-third-party-application-restrictions-for-your-organization/" target="blank">Please ensure no access restrictions are present</a>
</p>
<% end %>
<p>
<a href="mailto:support@huboard.com">Talk to us!</a>
</p>
</li>
</ul>
<a href="/<%= @parameters['user'] %>/<%= @parameters['repo'] %>/board/create" class="btn btn-large btn-primary" data-analytics-path='/board/creating/retry'>
Try again
</a>
<a href="/dashboard" class="btn btn-large primary" data-analytics-path='/board/creating/abandon'>
Go Home
</a>
</div>
<% end %>
</div>
</div>