Add new template 'lightweight-thymus' with fixes#121
Open
thomcsmits wants to merge 11 commits intodevelopmentfrom
Open
Add new template 'lightweight-thymus' with fixes#121thomcsmits wants to merge 11 commits intodevelopmentfrom
thomcsmits wants to merge 11 commits intodevelopmentfrom
Conversation
The template has code to pull the main analysis jupyter notebook from https://github.com/sooheelee/notebooks/tree/main/hubmap-hackathon-2024.
Switch out template to main analysis notebook instead of abbreviated one that pulls the analysis notebook from another repo.
lchoy
approved these changes
Mar 11, 2025
| "# This will error if the folder already exists\n", | ||
| "Repo.clone_from(git_url, repo_dir)\n", | ||
| "\n", | ||
| "repofilepath = f\"{repo_dir}/{repo_dir}/shlee-hh-lightweight-thymus/\"" |
Contributor
There was a problem hiding this comment.
It may be helpful to move line 72 after line 66 so that if line 70 errors if the folder already exists, the repofilepath is still set as it's referenced later.
There was a problem hiding this comment.
@lchoy, thanks or the review. Would you like me to go ahead and make this update? Anything else towards merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.