Skip to content

Conversation

@huandu
Copy link
Owner

@huandu huandu commented Jan 29, 2023

Per #94, add some cases for performance.

@coveralls
Copy link

coveralls commented Jan 29, 2023

Coverage Status

Coverage: 96.191%. Remained the same when pulling cc4fdfa on feature-benchmark into 1191d33 on master.

@huandu
Copy link
Owner Author

huandu commented Jan 29, 2023

Help wanted in this PR. I know current test cases are incomplete. I need some one to contribute more and representative cases.

@shoriwe
Copy link
Contributor

shoriwe commented Dec 25, 2025

This PR has 2 years open. Any reason to not include it in main? These benchmarks are better than no benchmarks at all

@huandu
Copy link
Owner Author

huandu commented Dec 29, 2025

@shoriwe I believe a fair performance benchmark should include test cases covering sufficiently typical application scenarios (rather than constructing cases with relatively obvious performance differences), fully considering the optimal implementations of various frameworks in these scenarios, and then conducting a side-by-side comparison. Currently, the testing in my PR is still quite inadequate, and there is no urgent demand for the performance benchmark itself. Therefore, it has been labeled as "help wanted" for an extended period without further progress. If you could provide assistance in this regard, it would be most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants