-
Notifications
You must be signed in to change notification settings - Fork 134
fix: sqlite: string interpolation incorrectly uses backslash escapes #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the exact reference to the documentation:
|
|
I just added support for the other cases where interpolation is incorrectly using backslash in SQLite |
|
Thanks for your contribution. |
huandu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues in comments.
|
@shoriwe Don't forget to fix failed cases. Thanks. |
Made all SQLite test pass by resolving to valid SQLite string syntax |
|
@huandu. I have updated the PR, let me know if it is now ready to merge |
|
LGTM. |
Patch for: #227