fix: schema incorrectly marks optional fields as required#2
Open
huaiyuWangh wants to merge 344 commits intomainfrom
Open
fix: schema incorrectly marks optional fields as required#2huaiyuWangh wants to merge 344 commits intomainfrom
huaiyuWangh wants to merge 344 commits intomainfrom
Conversation
… for selection methods
…stant-message refactor(chat): simple assistant message
…ToolRenderer to ToolRenderer
…stant-tools refactor(chat): initial setup for tool calls
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
* fix: completions width * refactor: rename visible items to filtered items (charmbracelet#1957) the name VisibleItems is misleading because it does not take into account the height of the list and returns all items that match the filter.
…acelet#1948) Ensure we update the textarea after inserting a newline to keep the cursor position accurate.
…t#1910) * ci: goreleaser build --snapshot on every commit to main Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: add preconditions Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: faster runners Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
* feat: lsp_restart Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * wip Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: typo Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: actually restart Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: simplify Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: render lsp restart Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: add lsp name to diag Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
… support (charmbracelet#1967) * fix(ui): prevent AAAA probe bleed in terminals without Kitty graphics support * refactor(ui): add an OS vendor type for Apple and use DRY for Kitty terminals * refactor(ui): do not export private symbols, fix a LookupEnv for mocks * refactor(ui): typo * refactor(ui): remove dead code * fix(ui): unify capability querying logic for terminal version and image capabilities --------- Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
…harmbracelet#1947) * feat(ui): add keybinding to copy chat message content to clipboard This commit backports the ability to copy the content of chat messages (assistant, user, and tool messages) to the clipboard using the 'c' key when the message is focused. * feat(ui): format tool calls and results for clipboard copying
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
…let#1848) This fixes two schema validation issues: 1. tools.ls incorrectly marked as required - Changed Tools.Ls and Config.Tools from omitzero to omitempty - The invopop/jsonschema library doesn't recognize Go 1.25's omitzero tag 2. lsp.command incorrectly marked as required - Removed jsonschema:"required" tag from LSPConfig.Command - The project's own crush.json doesn't include command field for gopls After this fix, users can use minimal configurations without being forced to specify tools.ls or lsp.command fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two schema validation issues that forced users to specify unnecessary fields in their configuration files.
tools.lsincorrectly marked as requiredTools.LsandConfig.Toolsfromomitzerotoomitemptyinvopop/jsonschemalibrary doesn't recognize Go 1.25'somitzerotaglsp.commandincorrectly marked as requiredjsonschema:"required"tag fromLSPConfig.Commandcrush.jsondoesn't include command field for goplsAfter this fix, users can use minimal configurations without being forced to specify
tools.lsorlsp.commandfields.Test plan
task schematoolsandtools.lsare now optional in generated schemalsp.commandis no longer marked as requiredCloses charmbracelet#1848