feat: readds transfer encoding to the header list.#77
Conversation
Transfer-Encoding property turns into a request field by the http handler, this commit adds it back for the sake of correctness.
codefromthecrypt
left a comment
There was a problem hiding this comment.
for unit test, maybe something like Test_host_GetProtocolVersion but GetRequestHeaderValues. Then in the test make it a table-driven test which has a field req *http.Request and in that you can set the special Host and TransferEncoding.
TCK would be good insulation as well, even though even if TCK is updated, the above unit test should be there. testRunner.testGetHeaderValuesRequest is awkward to do host/trasnfer encoding, so there after the table test, you could make separate calls like r.t.Run("host", func(t *testing.T) { with explicit impls which probably need to construct the http client requests.
|
I will try to land the intended change this week, in this PR or another |
|
closing as I don't have time to polish this and stale PRs don't tend to proceed. Someone can finish this including tests in another PR if they choose. |
Transfer-Encoding property turns into a request field by the http handler, this commit adds it back for the sake of correctness.
Still trying to figure out how to write the test.