[HSTACK] - add max_log_size hard limit + fallback to pseudo_cdf #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckpoints) Signed-off-by: Adrian Tanase <atanase@adobe.com>
Signed-off-by: Adrian Tanase <atanase@adobe.com>
Signed-off-by: Adrian Tanase <atanase@adobe.com>
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
aditanase
commented
Jun 17, 2025
| total_size, max_size | ||
| ))); | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
TODO: on the else branch (delta log size smaller than threshold) we should load the full table log.
cc @ccciudatu agree?
Signed-off-by: Adrian Tanase <atanase@adobe.com>
Collaborator
Author
|
already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The description of the main changes of your pull request
Related Issue(s)
Documentation