Open
Conversation
psean21c
reviewed
Nov 5, 2019
Collaborator
psean21c
left a comment
psean21c
left a comment
There was a problem hiding this comment.
LGTM but I am wondering if it's about unit test for Python coding.
ghost
approved these changes
Nov 8, 2019
ghost
suggested changes
Nov 10, 2019
| import pytest | ||
|
|
||
|
|
||
| @pytest.fixture(scope='function') |
There was a problem hiding this comment.
django gives you a client object if you subclass django.test.TestCase
|
|
||
|
|
||
| @pytest.fixture(scope='function') | ||
| def load_game_data(db): |
There was a problem hiding this comment.
might be better to just use pure fixturized data instead of trying to use our "production data".
| import pytest | ||
| from .fixtures import logged_in_client, load_game_data, create_user, get_client | ||
|
|
||
| class TestGameView: |
| response = logged_in_client.get(reverse('game', args=(1,))) | ||
|
|
||
| assert response.status_code == 200 | ||
| assert response.template_name[0] == 'front/game.html' |
There was a problem hiding this comment.
I would also check to make sure the expected values render in the template.
assert f'{game.title}' in response.content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.