An initial Version of my Component Library

[hrshmistry]

An initial version of my Component Library,

Hello everyone I have done my initial version of Component Library, I tried to make it responsive to mobile yet things like the menu are yet to be added. I tried to follow best practices but I need more practice so your feedback is important!

please give your reviews and feedback, where can I improve it.

Deployed link of development branch: Compact CSS

Thanks.

[shubambhasin]

I have reviewed your cmponent lib, everything is nicely done 👌

• just a small suggestion in the lib wesbite, the side nav goes a little up while scrolling, you can fix it. Rest is just fine

[tuhindas30]

Hi @hrshmistry,
Such a cool library you made. Loved it. The avatar and card section was quite attractive to the eye. Bohot e acchaa.

Few comments after going through:

• It is always a good idea to remove all commented out code. I have commented in one of the files but you should do it for all the files.
• rem makes thing responsive a bit. So, it is better to use that. px can be used when no other options are available.

Again, nicely organised code and good naming conventions. Nothing very serious. Just some small stuffs :)

[tuhindas30]

It's always a good practice to remove commented-out code to avoid distraction to the reviewer.

[hrshmistry]

yes absolutely, I will remove the commented code and refactor it.

[tuhindas30]

It's better to follow a particular sizing unit inside a class or inside an attribute. rem makes things more responsive whereas px doesn't.

[hrshmistry]

Sure thing it makes sense to use rem most of the time. I will change accordingly.

[hrshmistry]

I have reviewed your cmponent lib, everything is nicely done 👌

• just a small suggestion in the lib wesbite, the side nav goes a little up while scrolling, you can fix it. Rest is just fine

@shubambhasin Glad, you liked it, I have also noticed that issue Now fixing it soon and yes thank you for reviewing 😄

[hrshmistry]

Hi @hrshmistry,
Such a cool library you made. Loved it. The avatar and card section was quite attractive to the eye. Bohot e acchaa.

Few comments after going through:

• It is always a good idea to remove all commented out code. I have commented in one of the files but you should do it for all the files.
• rem makes thing responsive a bit. So, it is better to use that. px can be used when no other options are available.

Again, nicely organised code and good naming conventions. Nothing very serious. Just some small stuffs :)

Thank you @tuhindas30 😁, currently there are only a few components in the library but I will implement more thanks again for reviewing 🙌