This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Open
Conversation
Author
|
Actually looks like this breaks non multigrid environments... I'll have to think a bit |
Author
|
I'm not sure what the right solution is. Looks like pum_getpos returns relative positions when multigrid. I could special case whether editor or win is used for the relative property depending on if a gui is connected, but that feels like a hack. Any guidance would be appreciated |
Owner
|
The big change that relates to the documentation window had merged. Could you check the problem with latest compe? |
Author
Author
|
Changing the relative option in the window creation to win fixes this issue for multigrid environments, but I believe breaks it for normal ones. I'm not sure what the correct way to solves this is for both use cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #432 by modifying the floating window utility functions to use relative "win" rather than relative "editor". This is because in multigrid environments the position of the documentation window was incorrect as explained in the issue.