Fix R 4.7.0 (devel) build failure caused by lazyeval transitive dependency#179
Merged
Fix R 4.7.0 (devel) build failure caused by lazyeval transitive dependency#179
Conversation
…bust.R - Remove covr from Suggests (breaks transitive dep: covr → rex → lazyeval) - Add rlang to Imports in DESCRIPTION - Add importFrom(rlang, .data, .env) to NAMESPACE - Use .env pronoun in dplyr::mutate() calls in ED_robust.R - Update R dependency from >= 4.0.0 to >= 4.7.0 - No lazyeval references existed in drc code (was only transitive) Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/baca55f0-92b5-4c76-ae0e-340721b30e9b Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
hreinwald
March 27, 2026 15:36
View session
hreinwald
approved these changes
Mar 27, 2026
Owner
|
All tests R-CMD-check and test-coverage are failing now. Review these issues @copilot |
… from Suggests The R >= 4.7.0 requirement broke all non-devel CI jobs (release, oldrel, etc). Adding rlang to Imports failed on devel because rlang 1.1.7 also has the same PREXPR undefined symbol issue on R 4.7.0. The minimal correct fix is simply removing covr from Suggests to break the transitive dependency chain (covr -> rex -> lazyeval). The test-coverage workflow already installs covr independently via extra-packages: any::covr. Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/210cacd6-0b79-4134-849a-0fe7f7248972 Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Author
Investigated the CI failures — two issues with my initial commit:
Fixed in |
hreinwald
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lazyeval0.2.2 fails to compile on R 4.7.0 devel (undefined symbol: PREXPR). It's pulled in transitively viacovr → rex → lazyeval— drc never uses lazyeval directly.Changes
covrfromSuggeststo break the transitive dep chain. Thetest-coverage.yamlworkflow already installs covr independently viaextra-packages: any::covr, so coverage is unaffected.This is the minimal fix — no other changes are needed since drc has zero direct references to lazyeval. Adding
rlangto Imports or bumping the R dependency to>= 4.7.0was ruled out becauserlang1.1.7 also suffers from the samePREXPRundefined symbol issue on R 4.7.0 devel, and requiring R >= 4.7.0 would break all non-devel CI jobs (release, oldrel, etc.).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.