Retain Std. Error column in ED() and maED() interval output#176
Merged
Retain Std. Error column in ED() and maED() interval output#176
Conversation
- ED.drc.R: Stop dropping SE column for tfls, fls, and inv intervals - maED.R: Add model-averaged SE to kang interval output (4 cols) - test-ED.R: Update fls, tfls, inv tests to expect 4 columns - test-maED.R: Update kang test to expect 4 columns Agent-Logs-Url: https://github.com/hreinwald/drc/sessions/54327f64-7771-4c0f-b384-0b551db9c2a6 Co-authored-by: hreinwald <115988583+hreinwald@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
hreinwald
March 26, 2026 17:16
View session
hreinwald
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ED()withinterval = "tfls","fls", or"inv"drops the Std. Error column, returning only 3 columns (Estimate, Lower, Upper). Same issue inmaED()withinterval = "kang". All interval modes should return 4 columns: Estimate, Std. Error, Lower, Upper.Changes
R/ED.drc.R: Removed theedMat[, -2]/edColNames[-2]lines in thetfls,fls, andinvbranches. The existing assembly (cbind(edMat, intMat)) now naturally yields 4 columns for all interval types.R/maED.R: Added model-averaged SE (same Buckland formula already used elsewhere) to thekangbranch output, producing 4 columns instead of 3.test-ED.Randtest-maED.Rexpectations fromncol == 3toncol == 4for affected interval types.The non-interval case (
interval = "none") is unchanged — still returns Estimate + Std. Error only.