feat: move header tags to fix header#18
Merged
hpn777 merged 1 commit intohpn777:masterfrom Jan 23, 2025
Merged
Conversation
remithomas
force-pushed
the
move_header_tag_to_header
branch
3 times, most recently
from
37ece95 to
6269550
Compare
hpn777
reviewed
Jan 22, 2025
src/fixutils.ts
Outdated
| if (Array.isArray(item)) { | ||
| grupToFix(tag, item, headermsgarr) | ||
| } else { | ||
| headermsgarr.push(tag, '=', item, SOHCHAR) |
Owner
There was a problem hiding this comment.
I would move this check: if (headerFields[tag] !== true) {
directly here so you dont replicate entire statement:
if (Array.isArray(item)) {
grupToFix(tag, item, bodymsgarr)
} else {
bodymsgarr.push(tag, '=', item, SOHCHAR)
}
remithomas
force-pushed
the
move_header_tag_to_header
branch
from
6269550 to
4749a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.