Skip to content

Create code-review-comments.txt #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maalbano wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create code-review-comments.txt #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions code-review-comments.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
Code Review Comments from Michelle and Mike

Good points
- presentation was awesome
- good use of APIs (calendar, google gantt chart)
- index.js - good comments, clean organization. nothing weird. :D
- css is beautiful.

Points to improve
- update your README.md (it still says Rocket Academy Coding Bootcamp: Base Node App)
- very long functions need to be commented more, e.g. renderAddSchedule.
- // this loop is what I'm proudest of in this whole project.
- good to also say how it works in the comments.
- routes.js
- lines 143-150, look very similar to 164-161. Could this be refactored into a function?
- gantt-chart.ejs
- it's weird that the script for drawing the gantt, is above the html... we think maybe it should be below.
- calendar.ejs
- lines 22, and 23 contain /head and body tags. but these are already in the header and footer... something weird here.