Conversation
stevenvdb
approved these changes
May 16, 2024
Collaborator
stevenvdb
left a comment
stevenvdb
left a comment
There was a problem hiding this comment.
For me the changes you propose seem ok.
One remark about the note just above your modification:
Pageant should be running and your private key should...
For KULeuven/UHasselt this is not required. Maybe someone from another site can comment whether or not this note is still relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At KULeuven/UHasselt, we do not require SSH keys for any of the services anymore, thanks to the MFA and possible authentication setups of OnDemand, FileZilla, NX, and WinSCP.
This PR, in connection with PR #380, proposes a change in the FileZilla configuration page to distinguish between the correct setup for KUL site versus that of UGent/VUB/UAntwerpen sites.