Conversation
|
Largely looks fine to me, though I emphasise that I'm no expert on the scientific content. Definitely minor pointI think things like: Path(f"{workflow_path}/execute/t_1/e_0/pole_figure.png")can instead (because workflow_path / "execute/t_1/e_0/pole_figure.png"I believe that those two are equivalent. I would not regard that as a reason to reject a PR. |
|
Thanks @dkfellows ! Any review is a good review! Guy |
dkfellows
left a comment
There was a problem hiding this comment.
Code looks acceptable. I don't know the science to tell for sure, but there's nothing in there that looks wildly off.
|
Looks good @Gbowker. In the notebook, would you be able to add a link to the demo workflow template on the docs site that you used to generate the workflow (in the format https://docs.matflow.io/stable/reference/workflows.html#tension-damask-al, where you modify |
Demo which runs tensile simulations at 0, 45 and 90 to cube texture.