Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
RapidStreamHasherV3per #73, which is a stableHasher-inspired interface for streaming but doesn't directly implementstd::hash::Hasherdue to hash portability/stability concerns. (Perhaps one day we'll finish PortableHash...)I've also changed
rapidhash_v3_fileto use theRapidStreamHasherV3to a nearly 2x throughput improvement, although the stream hasher is still around 2x faster in most cases due to theReadtrait forcing us to copy into a local buffer.A
TODO(v5)is left to suggest a change to therapidhash_v3_file_inlineinterface to support aBUFFER_SIZEparameter (or perhaps a runtime one).