Fix unhandled promise rejection when prefetch request fails#1512
Closed
sskirby wants to merge 1 commit intohotwired:mainfrom
Closed
Fix unhandled promise rejection when prefetch request fails#1512sskirby wants to merge 1 commit intohotwired:mainfrom
sskirby wants to merge 1 commit intohotwired:mainfrom
Conversation
PrefetchCache.putLater calls request.perform() without catching errors. FetchRequest.perform() re-throws non-AbortErrors after delegating. In Safari, navigating away from a page while a prefetch is in-flight causes the browser to cancel the fetch with a TypeError instead of an AbortError. Since only AbortErrors are silently handled by FetchRequest, this surfaces as an unhandled rejection in Safari/iOS: TypeError: Unhandled Promise Rejection: Load failed Catch the rejection and evict the stale cache entry so that a fresh request is made when the user clicks the link.
Author
|
I am closing this PR because there are many more cases where reloading the page/navigating away will cause a "TypeError: Unhandled Promise Rejection: Load failed" in Safari. Most of which are very difficult to test for even if the project did have a suite of tests for Safari. In addition, the approach taken here has the risk of suppressing many other, unrelated, errors from error reporting tools like Sentry. Another option would be to ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrefetchCache.putLater calls request.perform() without catching errors. FetchRequest.perform() re-throws non-AbortErrors after delegating.
In Safari, navigating away from a page while a prefetch is in-flight causes the browser to cancel the fetch with a TypeError instead of an AbortError. Since only AbortErrors are silently handled by FetchRequest, this surfaces as an unhandled rejection in Safari/iOS:
TypeError: Unhandled Promise Rejection: Load failed
Catch the rejection and evict the stale cache entry so that a fresh request is made when the user clicks the link.
This failure mode is also apparent in Chrome when prefetching while "Offline"