Preserve hash fragment during frame navigation#1507
Open
redsun82 wants to merge 1 commit intohotwired:mainfrom
Open
Preserve hash fragment during frame navigation#1507redsun82 wants to merge 1 commit intohotwired:mainfrom
redsun82 wants to merge 1 commit intohotwired:mainfrom
Conversation
`fetchResponse.response.url` strips the hash fragment (browsers never send it over the wire), so when `loadResponse` updated `sourceURL` the hash was lost. This affected promoted URL state via `data-turbo-action="advance"` and the frame's `[src]` attribute. Re-attach the original hash from the frame's `sourceURL` after a non-redirect response. Partially addresses hotwired#598
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchResponse.response.urlstrips the hash fragment (browsers never send it over the wire), so whenFrameController.loadResponseupdatedsourceURLthe hash was lost from the frame's[src]and any promoted URL state.Re-attach the original hash from
sourceURLafter the response is received.Partially addresses #598