Improved: Added Me tab and enhanced permission handling for user list access with separate rule (#371)

[rakshit-upadhyay214]

Related Issues

#371

Description

Added a Me tab and enhanced permission handling for the user list. Users without the USERS_LIST_VIEW permission are now restricted from accessing the Users and Permissions screens. Also enabled all users with the base-level permission to reset their own password.

User with only USERS_APP_VIEW permission:

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @rakshit-upadhyay214, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines user access control and navigation within the application. It introduces a dedicated 'Me' tab for individual user profile management and restricts access to sensitive user and permission management screens based on a new USERS_LIST_VIEW permission. Additionally, it empowers users with basic app view permissions to manage their own passwords, enhancing self-service functionality and improving the overall security posture and user experience by tailoring visibility to assigned roles.

Highlights

• New 'Me' Tab Introduction: A dedicated 'Me' tab has been added, allowing users to view and manage their own details. This tab is visible to users who do not possess the broader USERS_LIST_VIEW permission, providing a personalized entry point.
• Enhanced Permission Handling for User and Permission Screens: Access to the 'Users' and 'Permissions' screens is now strictly controlled by a new USERS_LIST_VIEW permission. Users without this permission will not see these tabs or be able to navigate to these sections.
• Self-Service Password Reset for Basic Users: Users with the USERS_APP_VIEW permission are now empowered to reset their own passwords, improving self-service capabilities without requiring higher administrative privileges.
• Dynamic Root Path Redirection: The application's root path (/) now dynamically redirects users based on their permissions. Users with USERS_LIST_VIEW are directed to the 'Users' list, while others are sent to their 'Me' tab.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively introduces a 'Me' tab and enhances permission handling for the user list. Users lacking the USERS_LIST_VIEW permission are now correctly restricted from accessing the Users and Permissions screens, and are instead shown a 'Me' page with their own details. The changes also allow users with base-level permissions to reset their own passwords. The implementation across routing, components, and state management is consistent and well-executed. I have one minor suggestion to improve code quality by removing an unused variable.

[ymaheshwari1]

I think we should not add USERS_APP_VIEW permission, as adding it here will enable reset password feature for all the users, means that a random user can change password for admin or super users.

[rakshit-upadhyay214]

Users with only USERS_APP_VIEW can't do this as they are not allowed to access other users’ detail page. However, we can also introduce a separate permission specifically for password reset if needed.

[ymaheshwari1]

Yes, but if a user has USERS_LIST_VIEW permission, then he can access other users detail page and in that case the user can change other users password.