Fixed: Rename function not working properly (#352)

[R-Sourabh]

Related Issues

Closes #352

Short Description and Why It's Useful

This PR fixes the rename functionality for Scheduled Incoming Inventory jobs. The issue had two root causes:

1. Event Timing Conflict: When clicking the Save button, the ionBlur event on the input field was firing before the click event, causing cancelRename() to execute and hide the Save button before the click handler could fire.

2. Incorrect Field Reference: The updateJob method was using job.jobStatus instead of job.tempExprId when building the API payload, causing the update to fail.

Fixes:

• Added @mousedown.prevent to the Save button to prevent the input from losing focus when clicking, allowing the click event to fire properly
• Changed job.jobStatus to job.tempExprId in the updateJob method to use the correct field from the job object

Screenshots of Visual Changes before/after (If There Are Any)

N/A - No visual changes, only functional fixes.

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @R-Sourabh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical issues impacting the rename functionality for Scheduled Incoming Inventory jobs. It addresses an event timing conflict that prevented the "Save" button's click handler from executing properly and corrects an error in the API payload construction where an incorrect field was being used. These fixes ensure the reliable renaming of scheduled inventory jobs.

Highlights

• Event Handling Fix: Implemented @mousedown.prevent on the "Save" button to resolve an event timing conflict where the ionBlur event was firing before the click event, preventing the rename functionality from working correctly.
• API Payload Correction: Corrected the updateJob method to use job.tempExprId instead of job.jobStatus when constructing the API payload, ensuring the correct field is sent for job updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves two issues with the job renaming functionality. The first fix correctly uses @mousedown.prevent to address an event timing conflict between the input's blur event and the save button's click event, which is a standard and appropriate solution for this type of UI problem. The second fix corrects a data payload error by using the proper job.tempExprId field instead of job.jobStatus when updating a job. Both changes are well-targeted and correctly implemented, improving the reliability of the feature. The code is clean and the fixes are logical. The changes look good to merge.

[ymaheshwari1]

Closing as related issue is closed.