Fixed: chip selection on the PO page when coming from review page

[ymaheshwari1]

Related Issues

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @ymaheshwari1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the chip selection on the Purchase Order (PO) page was not correctly cleared when a user navigated back from a review page. By ensuring that the selectedMappingId is reset upon page entry, the UI now consistently displays the correct initial state, preventing stale selections and improving the overall user experience.

Highlights

• UI State Reset: The selectedMappingId property is now explicitly reset to an empty string within the ionViewDidEnter lifecycle hook of the Purchase Order page. This ensures that any previous chip selection is cleared when the page is entered, particularly after navigating back from a review page.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where the selected mapping chip on the Purchase Order page was not being deselected when navigating back from the review page. The fix, which involves resetting selectedMappingId within the ionViewDidEnter lifecycle hook, is appropriate. I've added one suggestion to also reset the fileColumns property in the same method to ensure a complete state reset and prevent stale data from persisting.

[gemini-code-assist]

To ensure the component state is fully reset when the view is re-entered, fileColumns should also be cleared, similar to content and other properties. This prevents stale data from being held in the component state when the user navigates back to this page.

      this.content = []
      this.fileColumns = []
      this.selectedMappingId = ""