Updated setup_mac to run puma instead of thin and to handle some of the ... #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he conditions of starting puma Puma takes a few seconds to launch and will be started in the background. So we curl until it is accepting requests. Also we are caging(kill -9) old pumas if they are running when the script is started. Side effect is that the script restarts puma.
Contributor
There was a problem hiding this comment.
I kinda feel like there should be some kind of timeout here, like 20 seconds or something. shrug
Contributor
Author
There was a problem hiding this comment.
Bootup seems to take between 5 and 7 seconds
wilkie
force-pushed
the
master
branch
2 times, most recently
from
b190898 to
33e3540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...conditions of starting puma
Puma takes a few seconds to launch and will be started in the background. So we curl until it is accepting requests.
Also we are caging(kill -9) old pumas if they are running when the script is started.
Side effect is that the script restarts puma.