Conversation
…orkflow Laravel 13 requires PHP ^8.3, so PHP 8.2 must be excluded from the matrix. The tidy workflow's git-auto-commit-action@v5 requires explicit contents:write permission to push formatting commits back to PR branches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
git-auto-commit-action fails with 'invalid reference' on PR events because actions/checkout defaults to a detached HEAD (merge commit). Checking out github.head_ref ensures the branch exists locally for the push. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel future-proofing
Rather than appending each new Laravel major version to an ever-growing list of constraints, this PR switches to open lower-bound (
>=) version constraints so that Laravel 13, 14, and beyond are supported automatically without requiring acomposer.jsonupdate on every release.Changes
composer.jsonlaravel/framework:^10.0 | ^11.0 | ^12.0→>=10.0orchestra/testbench:^8.0|^9.0 | ^10.0→>=8.0nunomaduro/collision:^7.0|^8.0→>=7.0larastan/larastan:^2.8|^3.0→>=2.8phpunit/phpunit:^10.0|^11.0→>=10.0.github/workflows/tests.ymlorchestra/testbench: 11.*Why this approach
The alternative (PR #217, generated by Laravel Shift) manually appends
^13.0to each constraint — but that requires the same update again when Laravel 14 ships. Using>=constraints means the package declares compatibility with all current and future versions from the minimum supported baseline, with CI covering the explicitly tested matrix.Closes #217