Skip to content

[fix] [common] Fix RawMessageImpl.getProperties() failed when the message metadata contains the same key but with different values#20

Open
horizonzy wants to merge 1 commit intomasterfrom
fix-get-properties-failed-with-msgMetadata-case
Open

[fix] [common] Fix RawMessageImpl.getProperties() failed when the message metadata contains the same key but with different values#20
horizonzy wants to merge 1 commit intomasterfrom
fix-get-properties-failed-with-msgMetadata-case

Conversation

@horizonzy
Copy link
Owner

Main Issue: apache#23925

Motivation

If the message metadata contains the same key but with different values, we should make the later value override the previous value.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant