Skip to content

Fix invalid code generation for null checks #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
horejsek merged 1 commit into from
Sep 29, 2025
Merged

Fix invalid code generation for null checks #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastjsonschema/draft04.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ def generate_items(self):
'{}_item'.format(self._variable),
'{}[{{{}_x}}]'.format(self._variable_name, self._variable),
)
if count == 0:
if not count:
self.l('pass')
else:
if items_definition:
Expand All @@ -437,7 +437,7 @@ def generate_items(self):
'{}_item'.format(self._variable),
'{}[{{{}_x}}]'.format(self._variable_name, self._variable),
)
if count == 0:
if not count:
self.l('pass')

def generate_min_properties(self):
Expand Down
6 changes: 3 additions & 3 deletions fastjsonschema/draft06.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ def __init__(self, definition, resolver=None, formats={}, use_default=True, use_

def _generate_func_code_block(self, definition):
if isinstance(definition, bool):
self.generate_boolean_schema()
return self.generate_boolean_schema()
elif '$ref' in definition:
# needed because ref overrides any sibling keywords
self.generate_ref()
return self.generate_ref()
else:
self.run_generate_functions(definition)
return self.run_generate_functions(definition)

def generate_boolean_schema(self):
"""
Expand Down
Loading