Feat: Add Google Authentication Configuration#33
Open
shrivastavshubham34 wants to merge 1 commit intohoppscotch:mainfrom
Open
Feat: Add Google Authentication Configuration#33shrivastavshubham34 wants to merge 1 commit intohoppscotch:mainfrom
shrivastavshubham34 wants to merge 1 commit intohoppscotch:mainfrom
Conversation
Adds GOOGLE_CALLBACK_URL and GOOGLE_SCOPE to the community configmap to allow for Google OAuth integration via Helm values.
Author
|
@nahidhasan94 can you merge PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces new configuration parameters to the
charts/shc/templates/configmap.yamlto support Google authentication.Previously, users could not directly configure Google OAuth callback URLs and scopes via the Helm chart. This enhancement enables seamless integration with Google as an authentication provider by allowing these settings to be managed through the chart's
values.yamlfile.Changes Made:
GOOGLE_CALLBACK_URLandGOOGLE_SCOPEto thecommunity-configConfigMap incharts/shc/templates/configmap.yaml. These new fields are populated from.Values.community.config.auth.google.callbackUrland.Values.community.config.auth.google.scoperespectively.Why this enhancement would be useful:
This enhancement provides greater flexibility and ease of deployment for users who wish to leverage Google authentication with Hoppscotch Community. It streamlines the configuration process by centralizing these settings within the Helm chart, aligning with standard Kubernetes deployment practices.
How to Test:
values.yamlto include the new Google authentication configuration undercommunity.config.auth.google:GOOGLE_CALLBACK_URLandGOOGLE_SCOPEenvironment variables are correctly populated in the deployed Hoppscotch Community pods by inspecting thecommunity-configConfigMap.