Set service type dynamically based on values#25
Open
dbendelman wants to merge 1 commit intohoppscotch:mainfrom
Open
Set service type dynamically based on values#25dbendelman wants to merge 1 commit intohoppscotch:mainfrom
dbendelman wants to merge 1 commit intohoppscotch:mainfrom
Conversation
Updated the service template to use `.Values.service.type` directly instead of a ternary operation. This change ensures better flexibility and aligns with user-defined configurations, particularly for LoadBalancer settings.
nahidhasan94
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit: https://github.com/JakobStadlhuber/hoppscotch-helm-charts/commit/2b8af595df8c4bff89adfb4fba3951ab9f0d1586
Updated the service template to use
.Values.service.typedirectly instead of a ternary operation. This change ensures better flexibility and aligns with user-defined configurations, particularly for LoadBalancer settings.Why?
Without this patch, the chart is not usable in a situation where the service must be of type ClusterIP and an ingress that's managed external to this chart exposes the service externally.