Add HStack renderable item culling tests #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
HStacktest coverage in line withVStackby verifyingrenderableItems(in:)correctly culls offscreen children and includes children that are moved into the query rect viaoffset.Description
ComposeUI/Tests/ComposeUITests/ComposeNodes/HorizontalStackNodeTests.swift:test_renderableItems_filtersOffscreenChildrenandtest_renderableItems_includesOffsetChildren.test_renderableItems_filtersOffscreenChildrenlays out a 3-childHStackand asserts that only the child overlapping the query rect is returned byrenderableItems(in:).test_renderableItems_includesOffsetChildrenapplies anoffsetto a child and asserts the offset child is included when its frame intersects the query rect.Testing
Codex Task
Note
Improves
HStackcoverage forrenderableItems(in:)behavior.test_renderableItems_filtersOffscreenChildrento ensure only overlapping children are returnedtest_renderableItems_includesOffsetChildrento ensure offset children intersecting the query rect are includedWritten by Cursor Bugbot for commit 543de0d. This will update automatically on new commits. Configure here.