fix(clickhouse): refactor locker #1
Open
+50
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Higurashi09473
changed the title
honeynil
reviewed
Jan 13, 2026
Owner
honeynil
left a comment
honeynil
left a comment
There was a problem hiding this comment.
Unlock() проверка SELECT может упасть (вернуть !hasLock), если между SELECT и последующим ALTER DELETE параллельно сработает cleanup expired lock из другого процесса или самого Lock().
Но в целом не страшно. так как наша цель освободить lock(), а если его уже нет(cleanup/expiry), миграция завершена безопасно, без влияния на нашу королеву
нужно выбрать между:
- Unlock(): return nil если !hasLock (graceful ignore).
- retry (1 попытка, 50мс sleep) перед ошибкой.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.