Make fields in public profile expand on click#35
Draft
emmawinston wants to merge 1 commit intohometown-fork:hometown-devfrom
Draft
Make fields in public profile expand on click#35emmawinston wants to merge 1 commit intohometown-fork:hometown-devfrom
emmawinston wants to merge 1 commit intohometown-fork:hometown-devfrom
Conversation
|
Hello @emmawinston, thanks for your proposal. Sadly I have no skills to help regarding the enhancement you propose, have you some ideas about the main web view implementation? I know the PR has been open for a while, sorry for not getting back to you sooner. |
4913b10 to
2bb47f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the request of a friend camp user, I've written some JS to make the boxes on public profile expand to show the full text on click/tap.
The only way to view this text in vanilla Mastodon web view is mousing over to see it as an alt title label - there is currently no way to view it on iOS touch devices without using a client (not sure about Android). This alternative should work on any device. Cursor users will see a pointer cursor on hover, which will only show up if text is overflowed and partially hidden.
This works great on public profiles, but I am having trouble implementing it in the main web view, I believe because of the order in which webpack loads things, so would appreciate any help with this you can offer. The one thing I have not yet tried is rewriting and mounting the script as a React component but I'd like to avoid this if possible since it seems like overkill for something that is both extremely functionally simple and not reused across multiple React contexts.