Skip to content

Make fields in public profile expand on click#35

Draft
emmawinston wants to merge 1 commit intohometown-fork:hometown-devfrom
emmawinston:expand-fields-profile
Draft

Make fields in public profile expand on click#35
emmawinston wants to merge 1 commit intohometown-fork:hometown-devfrom
emmawinston:expand-fields-profile

Conversation

@emmawinston
Copy link
Collaborator

@emmawinston emmawinston commented Nov 30, 2019

At the request of a friend camp user, I've written some JS to make the boxes on public profile expand to show the full text on click/tap.

The only way to view this text in vanilla Mastodon web view is mousing over to see it as an alt title label - there is currently no way to view it on iOS touch devices without using a client (not sure about Android). This alternative should work on any device. Cursor users will see a pointer cursor on hover, which will only show up if text is overflowed and partially hidden.

This works great on public profiles, but I am having trouble implementing it in the main web view, I believe because of the order in which webpack loads things, so would appreciate any help with this you can offer. The one thing I have not yet tried is rewriting and mounting the script as a React component but I'd like to avoid this if possible since it seems like overkill for something that is both extremely functionally simple and not reused across multiple React contexts.

@ghost ghost added the enhancement New feature or request label Jun 30, 2020
@ghost ghost marked this pull request as draft July 6, 2020 08:26
@ghost
Copy link

ghost commented Aug 1, 2020

Hello @emmawinston, thanks for your proposal. Sadly I have no skills to help regarding the enhancement you propose, have you some ideas about the main web view implementation? I know the PR has been open for a while, sorry for not getting back to you sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant