Skip to content

Conversation

@pkshirsagar904
Copy link

@pkshirsagar904 pkshirsagar904 commented Jan 27, 2025

DataPull PR

  • Added code changes to move json from the history folder to non-scheduled folder
  • This change would improve the loading of the jsons from the history folders

Added

  • method to move non-scheduled jobs from history folder.

Changed

  • changed DataPullRequestProcessor.java
  • changed DatapullclientApplication.java

PR Checklist Forms

  • CHANGELOG.md updated
  • Reviewer assigned
  • PR assigned (presumably to submitter)
  • Labels added (enhancement, bug, documentation)

}
catch (Exception e) {
log.error("Error processing files: " + e.getMessage());
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a finally block and close the s3client.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding a finally block to close s3 client, and restarting the application locally.

2025-01-27 18:02:34.349 [restartedMain] INFO  o.a.catalina.core.StandardService - Stopping service [Tomcat]
2025-01-27 18:02:34.386 [restartedMain] ERROR o.s.boot.SpringApplication - Application run failed
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'dataPullRequestHandler': Unsatisfied dependency expressed through field 'service'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataPullRequestProcessor': Invocation of init method failed; nested exception is com.amazonaws.SdkClientException: Unable to execute HTTP request: s3.amazonaws.com
Caused by: com.amazonaws.SdkClientException: Unable to execute HTTP request: s3.amazonaws.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants