[sidebar] set max-width for item-text#4893
Merged
balloob merged 1 commit intohome-assistant:devfrom Feb 17, 2020
Merged
Conversation
balloob
approved these changes
Feb 17, 2020
Member
|
Thanks! Developer tools is 3 words in your language ? |
Member
Author
|
@balloob it says "tools for developers" |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When item text is wrapped, flex container in
paper-icon-itemshrinks icon div which causes misaligned text. Set max width for the item text to prevent this. 56px is the default width of icon spacer div (here) inpaper-icon-item.Better fix is PolymerElements/paper-item#133 but that project doesn't seem to be active and it's unlikely that fix will be reviewed soon.
Before:

After:

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: