Skip to content

Migrate ha-icon-button to webawesome#29622

Open
wendevlin wants to merge 14 commits intodevfrom
migrate-ha-icon-button
Open

Migrate ha-icon-button to webawesome#29622
wendevlin wants to merge 14 commits intodevfrom
migrate-ha-icon-button

Conversation

@wendevlin
Copy link
Member

Proposed change

  • migrate ha-icon-button to use ha-button
    • --mdc-icon-button-size --> --ha-icon-button-size
    • Add new selected prop for ha-dropdown to highlight svg-icon-button when dropdown is open.
  • remove-mwc-icon-button dependency
  • Migrate a wrapped ha-icon-buttons to ha-icon-buttons

Screenshots

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to backend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

Copy link
Contributor

@uptimeZERO uptimeZERO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Very good work otherwise ❤️

@home-assistant home-assistant bot marked this pull request as draft February 13, 2026 15:20
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@wendevlin wendevlin marked this pull request as ready for review February 16, 2026 08:16
@home-assistant home-assistant bot requested a review from uptimeZERO February 16, 2026 08:16
Comment on lines +50 to +51
href=${ifDefined(this.href)}
target=${ifDefined(this.target)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe even here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webawesome defines a type string. Technically they have an ifDefined in wa-button so yes we should, but we'll get a type warning. Should I pass it as prop?

@timmo001

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants