Open
Conversation
…-button component
…dundant CSS rules
uptimeZERO
requested changes
Feb 13, 2026
Contributor
uptimeZERO
left a comment
There was a problem hiding this comment.
A few minor comments. Very good work otherwise ❤️
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bramkragten
reviewed
Feb 16, 2026
bramkragten
reviewed
Feb 16, 2026
Comment on lines
+50
to
+51
| href=${ifDefined(this.href)} | ||
| target=${ifDefined(this.target)} |
Member
Author
There was a problem hiding this comment.
Webawesome defines a type string. Technically they have an ifDefined in wa-button so yes we should, but we'll get a type warning. Should I pass it as prop?
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
ha-icon-buttonto useha-button--mdc-icon-button-size-->--ha-icon-button-sizeselectedprop forha-dropdownto highlight svg-icon-button when dropdown is open.awrappedha-icon-buttonstoha-icon-buttonsScreenshots
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: