Skip to content

Add tuya/climate halves precision if the sensor supports it#43666

Closed
3v1n0 wants to merge 1 commit intohome-assistant:devfrom
3v1n0:tuya-halves
Closed

Add tuya/climate halves precision if the sensor supports it#43666
3v1n0 wants to merge 1 commit intohome-assistant:devfrom
3v1n0:tuya-halves

Conversation

@3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Nov 26, 2020

Devices may use a temperature divider of 2, in such case tuyah won't
properly handle its halves values using whole precision.

Fix this by checking if the device supports halves, and in such case to
return such precision

This needs PaulAnnekov/tuyaha#54

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @3v1n0,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @ollo69, mind taking a look at this pull request as its been labeled with an integration (tuya) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the waiting-for-upstream We're waiting for a change upstream label Nov 26, 2020
@frenck frenck marked this pull request as draft November 26, 2020 16:14
@frenck
Copy link
Member

frenck commented Nov 26, 2020

Converted PR to draft and added a label to indicate we are awaiting upstream for this.

Devices may use a temperature divider of 2, in such case tuyah won't
properly handle its halves values using whole precision.

Fix this by checking if the device supports halves, and in such case to
return such precision

This needs PaulAnnekov/tuyaha#54
@MartinHjelmare MartinHjelmare changed the title tuya/climate: Add support for halves precision if the sensor supports it Add tuya/climate halves precision if the sensor supports it Nov 26, 2020
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 26, 2021
@frenck
Copy link
Member

frenck commented Jan 28, 2021

This PR has been in a draft and running stale without activity since November.
I'll go ahead and close this PR for now. Feel free to re-open the PR again when upstream becomes available. Contributions are always appreciated 👍

@frenck frenck closed this Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed integration: tuya small-pr PRs with less than 30 lines. stale waiting-for-upstream We're waiting for a change upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants