Add tuya/climate halves precision if the sensor supports it#43666
Closed
3v1n0 wants to merge 1 commit intohome-assistant:devfrom
Closed
Add tuya/climate halves precision if the sensor supports it#436663v1n0 wants to merge 1 commit intohome-assistant:devfrom
3v1n0 wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
Member
|
Converted PR to draft and added a label to indicate we are awaiting upstream for this. |
Devices may use a temperature divider of 2, in such case tuyah won't properly handle its halves values using whole precision. Fix this by checking if the device supports halves, and in such case to return such precision This needs PaulAnnekov/tuyaha#54
21 tasks
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Member
|
This PR has been in a draft and running stale without activity since November. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices may use a temperature divider of 2, in such case tuyah won't
properly handle its halves values using whole precision.
Fix this by checking if the device supports halves, and in such case to
return such precision
This needs PaulAnnekov/tuyaha#54
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: