Skip to content

Conversation

@cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 28, 2025

Proposed change

https://github.com/LouisChrist/pyblu/releases/tag/v2.0.2
https://github.com/LouisChrist/pyblu/releases/tag/v2.0.3
https://github.com/LouisChrist/pyblu/releases/tag/v2.0.4
LouisChrist/pyblu@v2.0.1...v2.0.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p marked this pull request as ready for review July 28, 2025 20:41
@home-assistant
Copy link

Hey there @thrawnarn, @LouisChrist, mind taking a look at this pull request as it has been labeled with an integration (bluesound) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bluesound can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bluesound Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdce8p cdce8p added the waiting-for-upstream We're waiting for a change upstream label Jul 28, 2025
@cdce8p
Copy link
Member Author

cdce8p commented Jul 28, 2025

We could not detect an OSI-approved license for pyblu@2.0.2: None -- None -- []

Seems the release metadata didn't work out properly. It should've been set to MIT still.
There is an upstream PR (merged) which changes the packing from poetry to hatchling / uv, which accidentally removed the license metadata. But that wasn't part of the tagged commit.

LouisChrist/pyblu#61 (comment)

@LouisChrist Would you mind taking a look at it? I believe it would be enough to re-add license = "MIT" and do a new release.

@LouisChrist
Copy link
Contributor

LouisChrist commented Jul 28, 2025

This should be fixed in 2.0.3. It still seems to be broken. I’ll take a look at it tomorrow.

I yanked 2.0.2 and 2.0.3

@cdce8p cdce8p force-pushed the update-pyblu-2.0.2 branch from 152c5a6 to 8818a2b Compare July 28, 2025 23:20
@cdce8p
Copy link
Member Author

cdce8p commented Jul 28, 2025

This should be fixed in 2.0.3. It still seems to be broken. I’ll take a look at it tomorrow.

I yanked 2.0.2 and 2.0.3

From what I can see it actually looks fine. PyPI now lists License Expression: MIT for 2.0.3 which is correct. All that's really needed now is to un-yank the last release and this would be ready.

https://pypi.org/project/pyblu/2.0.3/#description

@cdce8p cdce8p changed the title Update pyblu to 2.0.2 Update pyblu to 2.0.3 Jul 28, 2025
@LouisChrist
Copy link
Contributor

This should be fixed in 2.0.3. It still seems to be broken. I’ll take a look at it tomorrow.
I yanked 2.0.2 and 2.0.3

From what I can see it actually looks fine. PyPI now lists License Expression: MIT for 2.0.3 which is correct. All that's really needed now is to un-yank the last release and this would be ready.

https://pypi.org/project/pyblu/2.0.3/#description

The license was correct, but the wheel was broken I think. 2.0.4 should be working.

@cdce8p cdce8p force-pushed the update-pyblu-2.0.2 branch from 8818a2b to aef86f6 Compare July 29, 2025 19:28
@cdce8p cdce8p changed the title Update pyblu to 2.0.3 Update pyblu to 2.0.4 Jul 29, 2025
@cdce8p cdce8p added smash Indicator this PR is close to finish for merging or closing and removed waiting-for-upstream We're waiting for a change upstream labels Jul 29, 2025
@joostlek joostlek merged commit 62713b1 into home-assistant:dev Jul 29, 2025
84 of 86 checks passed
@cdce8p cdce8p deleted the update-pyblu-2.0.2 branch July 29, 2025 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency integration: bluesound Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants